Added typehints to the foliumap.Map init #813
Conversation
* Remove unused control * Remove unused draw output control
* Enable xarray dataset in add_raster_legacy * Remove datapane * Update install package function
…able name given (opengeos#529) lon was hard-coded as a variable name in the shifting logic, and was ignoring the variable being passed to the function. This fixes the bug
* Add images_to_tiles function * Fix CI test * Skip notebook 42 * Fix docs build error * Add demo GIF
* Update GitHub Actions * Update docs-build * Update docs-build * Update CI * Update CI * Pin GDAL version * Update CI * activate conda env * conda init * Add bash * Add bash * Add bash * Add checkout * Update workflows * Update ubuntu and windows * Update workflows * Update windows * Fix data error * Update notebook GitHub URL
* Add GitHub Actions for checking PR file size * Update workflows * Update workflows * Skip GDAL test * skip gdal check * Change pip gdal * Fix stac tile error * Fix gdal installation error * Fix stac tile error * Fix gdal installation
* Add changelog script * Remove changelog_update.md * Update gitignore
* Add image_to_geotiff function * Add to_cog option
* Add functions for executing MapLibre notebook * Add GIF notebook example * Improve function
* Add MapTiler style function * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
Initially, I removed the **kwargs completely, but now I realize that shouldn't be the case. Firstly, this change causes the docs builder to crash since ipyleaflet parameters are added to a foliumap in some places. Secondly, it removes the ability to use folium.Map parameters that are not part of the foliumap.Map class. For now i have reintroduced the **kwargs and placed them bank in the super.init I might be missing something, so please review this PR critically 😄 |
|
Some parameter names are different between folium and ipylealet, such as |
|
Yes, I figured. That why I have this mapping: This seems to works, but the problem might be that the current selection of parameters might imply that those are the only options, while it is still possible to pass folium Map parameters (for example crs, no_touch etc.). Maybe the best option here is to add them all to the foliumap.Map, to make sure the IDE shows all available parameters. By still leaving the **kwargs in, it should work completely interchangerable with ipyleaflet, while having a 100% covered IDE doc popup for all parameters that actually work for Folium. I could extend this PR later this week. |
giswqs
force-pushed
the
master
branch
2 times, most recently
from
970bacf to
e3e30d6
Compare
|
I did some prunning to reduce the repo size from 1.6 GB to 250 MB. The seems to have caused issues for your PR. Sorry about that. You might want to clone the repo again and create a new branch. Then just overwrite the few files you have modified. This is can avoid the merge conflict issue. |
|
Your pull request are in conflict @JJFlorian, please fix it! |
|
@JJFlorian Sorry to close the PR for now. Otherwise, you will keep receiving the merge conflict notifications from pre-commit. If you want to continue the work, please clone the repo again and overwrite the folium.py. Sorry for the inconvience. |
As discussed in my previous PR: here a PR with just the Init updates on foliumap.Map. This enhances the docs popup in IDEs: